Skip to content

Improve usability outside POET

Max Lübke requested to merge ml/improve-API into poet

Hi @delucia ,

As previously discussed, I have reworked our Phreeqc API, which now provides PhreeqcMatrix and PhreeqcEngine to interact with Phreeqc.

I added some test cases, which are also run on a commit using the gitlab CI. Currently there are only test cases for PhreeqcMatrix, but I plan to implement some for the engine as well. Therefore the merge request is still marked as a draft.

But you can have a look at the new API. Just have a look at the source code of poet/test/testPhreeqcMatrix.cpp for code examples.

Merge request reports